Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antd Input: To use with react-number-format customInput feature. #46999

Open
C3maLi opened this issue Jan 16, 2024 · 9 comments
Open

Antd Input: To use with react-number-format customInput feature. #46999

C3maLi opened this issue Jan 16, 2024 · 9 comments
Labels
🚌 External Dependency help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@C3maLi
Copy link

C3maLi commented Jan 16, 2024

Reproduction link

https://stackblitz.com/edit/react-m9nrou

Steps to reproduce

In the example, it will be seen that the Input field does not work properly when numeric values are entered."

What is expected?

I can't determine for sure if this problem is caused by Antd Input. However, this problem is not encountered when using the Input of another library.

What is actually happening?

What I expect is that the values entered in the Input field work properly.

Environment Info
antd 5.13.3
React 18
System Windows 11
Browser Chrome, Mozilla, Opera.

I'm not sure if this problem is caused by Antd Input or react-number-format, I just wanted to open this issue because I saw that it worked correctly when I used another framework Input.
Note: It works smoothly in version 5.10.3

A sample of the material is also available, you can also examine it.

@zombieJ
Copy link
Member

zombieJ commented Jan 16, 2024

antd Input both use selection operation. I guess it's some sequence conflict of it.

@zombieJ zombieJ added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 🚌 External Dependency and removed unconfirmed labels Jan 16, 2024
Copy link
Contributor

Hello @C3maLi. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @C3maLi,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@RezaGhx
Copy link

RezaGhx commented Jan 16, 2024

antd Input both use selection operation. I guess it's some sequence conflict of it.

is this their issue? cause someone mentioned it would be fine by downgrading antd's version.

@C3maLi C3maLi changed the title Antd Input: To use with react-number-format customput feature. Antd Input: To use with react-number-format customInput feature. Jan 16, 2024
@yociduo
Copy link
Contributor

yociduo commented Feb 1, 2024

#46200
react-component/input#54
It is related to this change, react-number-format can't get the real target.

@mslotvinskij
Copy link
Contributor

It would be great if the Ant Design input for numbers could incorporate the same features as the combination of React Number Format (react-number-format) and the Ant Design input. At the very least, there's a need for an additional fix to ensure compatibility with the React Number Format library.

Copy link

stackblitz bot commented Mar 17, 2024

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@github-actions github-actions bot removed the Inactive label Mar 17, 2024
@IssueHuntBot
Copy link

@pgeimer has funded $25.00 to this issue.


@C3maLi
Copy link
Author

C3maLi commented Apr 20, 2024

I created a temporary solution, maybe it will be useful to you
I will try to find a solution for this issue later.

@yociduo, @mslotvinskij @RezaGhx

https://stackblitz.com/edit/react-m9nrou-by6vji

@rayyventura
Copy link

I created a temporary solution, maybe it will be useful to you I will try to find a solution for this issue later.

@yociduo, @mslotvinskij @RezaGhx

https://stackblitz.com/edit/react-m9nrou-by6vji

Did you find a better solution ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚌 External Dependency help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

7 participants