Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal afterClose does not pass event #4787

Closed
SamyukthaJ opened this issue Feb 8, 2017 · 3 comments · Fixed by #5042
Closed

Modal afterClose does not pass event #4787

SamyukthaJ opened this issue Feb 8, 2017 · 3 comments · Fixed by #5042
Assignees
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@SamyukthaJ
Copy link

SamyukthaJ commented Feb 8, 2017

afterClose function does not pass the event argument.
Similarly Popconfirm onConfirm, onCancel does not pass the event.

event.stopPropagation() needed to be called on both the above handlers but event not passed.

@ddcat1115
Copy link
Contributor

afterClose just indicates that the closing action has been completed, you can use onOk onCancel in Modal.

And the event argument has been left out in these handlers:

  • Modal: onOk
  • Popconfirm: onConfirm onCancel

Could you give us a PR to fix it? 😃

@ddcat1115 ddcat1115 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Feb 8, 2017
@afc163
Copy link
Member

afc163 commented Feb 19, 2017

@SamyukthaJ

@lock
Copy link

lock bot commented May 2, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants