Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering date manually in custom date-fns date picker with format #48509

Open
jvnm-dev opened this issue Apr 17, 2024 · 3 comments
Open

Entering date manually in custom date-fns date picker with format #48509

jvnm-dev opened this issue Apr 17, 2024 · 3 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@jvnm-dev
Copy link

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  • Open minimal reproducible example
  • Enter date manually character by character i.e. "04/17/2024"
  • When entering the first 2 of 2024 the bug occurs

What is expected?

The date should be 04/17/2024

What is actually happening?

The date is 04/17/0002. If I continue to type 2024 it becomes 0002024.

Environment Info
antd 5.16.2
React 18.2.0
System macOS Sonoma 14.2
Browser Arc 1.38.0
@zombieJ
Copy link
Member

zombieJ commented Apr 17, 2024

Seems date-fns will parse invalidate format as a date object. Pls feel free RP to rc-picker : )

@zombieJ zombieJ added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. and removed unconfirmed labels Apr 17, 2024
Copy link
Contributor

Hello @jvnm-dev. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @jvnm-dev,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@jvnm-dev
Copy link
Author

jvnm-dev commented Apr 23, 2024

Seems date-fns will parse invalidate format as a date object. Pls feel free RP to rc-picker : )

What does RP mean? Should I open an issue to rc-picker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

2 participants