Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table demo示例中远程加载数据,第一次会出现两次请求的bug #48550

Closed
fakerlogic opened this issue Apr 19, 2024 · 3 comments · Fixed by #48560
Closed

table demo示例中远程加载数据,第一次会出现两次请求的bug #48550

fakerlogic opened this issue Apr 19, 2024 · 3 comments · Fixed by #48560
Labels
📝 Documentation help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@fakerlogic
Copy link

Reproduction link

https://ant.design/components/table-cn#components-table-demo-ajax

Steps to reproduce

第一次进入页面会请求两次

What is expected?

请求一次

What is actually happening?

请求了两次

Environment Info
antd undefined
React react
System mac os 14.4.1
Browser chrome 123.0.6312.124

第一次请求完了,会设置tableParams,里面有个total参数肯定变了,导致在useEffect中又请求了一次。改一下依赖项就好了

@zombieJ
Copy link
Member

zombieJ commented Apr 19, 2024

示意不太严谨,来帮忙提个 PR 吧~

@zombieJ zombieJ added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 📝 Documentation and removed unconfirmed labels Apr 19, 2024
Copy link
Contributor

Hello @fakerlogic. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @fakerlogic,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@afc163
Copy link
Member

afc163 commented Apr 22, 2024

最好把这个例子改成用 useQuery 或 useSWR 实现。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Documentation help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants