Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Collapse to <details /> #48974

Open
afc163 opened this issue May 18, 2024 · 3 comments
Open

Refactor Collapse to <details /> #48974

afc163 opened this issue May 18, 2024 · 3 comments
Labels
⌨️ Accessibility help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@afc163
Copy link
Member

afc163 commented May 18, 2024

Suggested by https://x.com/yisibl/status/1791813544104849708

图片

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#browser_compatibility

@afc163 afc163 added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 💡 Feature Request and removed unconfirmed labels May 18, 2024
Copy link
Contributor

Hello @afc163. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @afc163,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@yisibl
Copy link

yisibl commented May 18, 2024

一旦浏览器支持了 ::details-content( 暂定名称) 伪元素,我们就可以不用通过 JS 计算高度来产生过渡动画,这样性能更好。
示例:https://codepen.io/yisi/pen/dyEYxBY
名称讨论:w3c/csswg-drafts#9951

@yisibl
Copy link

yisibl commented May 18, 2024

tree 组件也可以用 <details> 元素试试,目前应该有一些用例无法满足,可以给 CSSWG 或者 HTML 规范提 issue,以此推动原生组件的快速发展,最终 Antd 等组件库也会从中受益。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ Accessibility help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

2 participants