You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Browser and its version: Chrome 56.0.2924.87 (64 bits)
What did you do? Please provide steps to re-produce your problem.
I modified the default colors to create a custom theme by importing a custom less file, and used the Progress (type circle) component with a success status.
What did you expect?
I expected the Progress component to use my custom theme's colors (the success-color).
What happens?
The Progress component does not use my custom theme's colors, because they are hardcoded in JavaScript in the Progress component file.
If you provide the ability to use custom colors (which is great!), every component should use them and there should be a single file to define them (whether it's a JSON, a JS, or a LESS file). Wouldn't it be possible to set the colors for the SVG shape in CSS only (I don't know much about SVG) ?
The text was updated successfully, but these errors were encountered:
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.
lockbot
locked as resolved and limited conversation to collaborators
May 2, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Environment (required)
What did you do? Please provide steps to re-produce your problem.
I modified the default colors to create a custom theme by importing a custom less file, and used the Progress (type circle) component with a
success
status.What did you expect?
I expected the Progress component to use my custom theme's colors (the
success-color
).What happens?
The Progress component does not use my custom theme's colors, because they are hardcoded in JavaScript in the Progress component file.
If you provide the ability to use custom colors (which is great!), every component should use them and there should be a single file to define them (whether it's a JSON, a JS, or a LESS file). Wouldn't it be possible to set the colors for the SVG shape in CSS only (I don't know much about SVG) ?
The text was updated successfully, but these errors were encountered: