Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress component's colors are hardcoded #5002

Closed
WaldoJeffers opened this issue Feb 22, 2017 · 2 comments
Closed

Progress component's colors are hardcoded #5002

WaldoJeffers opened this issue Feb 22, 2017 · 2 comments

Comments

@WaldoJeffers
Copy link

Environment (required)

  • antd version: 2.7.2
  • OS and its version: Windows 10
  • Browser and its version: Chrome 56.0.2924.87 (64 bits)

What did you do? Please provide steps to re-produce your problem.

I modified the default colors to create a custom theme by importing a custom less file, and used the Progress (type circle) component with a success status.

What did you expect?

I expected the Progress component to use my custom theme's colors (the success-color).

What happens?

The Progress component does not use my custom theme's colors, because they are hardcoded in JavaScript in the Progress component file.

If you provide the ability to use custom colors (which is great!), every component should use them and there should be a single file to define them (whether it's a JSON, a JS, or a LESS file). Wouldn't it be possible to set the colors for the SVG shape in CSS only (I don't know much about SVG) ?

@afc163 afc163 closed this as completed in 39fd6b6 Feb 22, 2017
@afc163
Copy link
Member

afc163 commented Feb 22, 2017

Actually, I don't know we can stying svg by css before your issue. 😃

@lock
Copy link

lock bot commented May 2, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants