Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification doesn't support customize style #5893

Closed
lixiaoyang1992 opened this issue Apr 25, 2017 · 7 comments
Closed

Notification doesn't support customize style #5893

lixiaoyang1992 opened this issue Apr 25, 2017 · 7 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@lixiaoyang1992
Copy link
Contributor

What problem does this feature solve?

when description is long and with split line, like :

[WARNING]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building ***
[INFO] ------------------------------------------------------------------------

I want to customize the style.

What does the proposed API look like?

notification.success({
  style : { width: 300},
  message: 'my title',
  description: 'a long long string'
})
@lixiaoyang1992
Copy link
Contributor Author

If you accept the feature, I can PR

@benjycui
Copy link
Contributor

And how about message?

And, if we accept this feature, we had better to support className, too.

@lixiaoyang1992
Copy link
Contributor Author

According to Notification API, message means title.

And of coerce, we should support className.

@benjycui
Copy link
Contributor

benjycui commented May 3, 2017

The conclusion is that we need to add style and className to antd.notification antd.message

@benjycui benjycui added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. and removed 🗣 Discussion labels May 3, 2017
@benjycui
Copy link
Contributor

benjycui commented May 3, 2017

@lixiaoyang1992 could you PR to add these features?

@lixiaoyang1992
Copy link
Contributor Author

OK

@lock
Copy link

lock bot commented May 5, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

2 participants