notifications with custom placement are overlaping

[jakubkosinski]

Version

2.9.3

Environment

macOS, Chrome 58, Safari 10.1

Reproduction link

http://codepen.io/anon/pen/gWwJvw

Steps to reproduce

1. Set custom placement for a notification
2. Open a notification with custom placement
3. Open another notification with the same custom placement

What is expected?

Notifications are not overlaping

What is actually happening?

Notifications are overlaping

[benjycui]

ping @ystarlongzi

[benjycui]

But it works fine here https://ant.design/components/notification/#components-notification-demo-placement

[benjycui]

@ystarlongzi it works fine with notification.confg, but it's broken with notification.open({ placement: ... })

[benjycui]

Related: #5894

[ystarlongzi]

@benjycui Get, i'll fix it.

[tvrcgo]

@benjycui @ystarlongzi 关于这个问题还有一个场景：

• A 组件调用 notification.success 不设置 placement，弹窗默认从右上角出
• B 组件调用 notification.success 设置了 placement = bottomRight，弹窗从右下角出
• A 组件再调用 notification.success 不设置 placement，弹窗变成从右下角出，默认 placement 被改了

只要某个地方设置了一次 custom placement，往后的所有 default placement 都会被改变。

这是正常的吗？

---

版本：antd@2.12.4

[djyde]

@benjycui Should defaultPlacement be immutable?

[benjycui]

Please provide a re-producible demo: http://codepen.io/benjycui/pen/KgPZrE?editors=001

[tvrcgo]

@benjycui https://codepen.io/tvrcgo/pen/mMmgRy

[benjycui]

@ystarlongzi why do you modify the defaultPlacement in here

[afc163]

@ystarlongzi

[djyde]

I am gonna to fix it. Should I?

[benjycui]

@djyde yep, thanks.

[djyde]

But the notification.config(options) is conflict with immutable default placement.

[benjycui]

@djyde I will handle this, there are several bugs in notification, not just the one which you had pointed it out.