Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

不要在 label 上设置 required 属性 #985

Closed
yiminghe opened this issue Feb 2, 2016 · 1 comment
Closed

不要在 label 上设置 required 属性 #985

yiminghe opened this issue Feb 2, 2016 · 1 comment
Assignees
@benjycui

Comments

@yiminghe
Copy link
Contributor

yiminghe commented Feb 2, 2016

ant-design/components/form/FormItem.jsx

Line 118 in ce9e377

<label htmlFor={props.id || this.getId()} className={this._getLayoutClass(labelCol)} required={required} key="label">

facebook/react#5963
benjycui added a commit that referenced this issue Feb 2, 2016
@benjycui
fix: should not set required to label #985
b42fb9f
@benjycui benjycui mentioned this issue Feb 2, 2016
Merged
afc163 added a commit that referenced this issue Feb 3, 2016
@afc163
Merge pull request #986 from ant-design/fix-formItem
c0154d3 
fix: should not set required to label #985
@lock
Copy link

lock bot commented May 6, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benjycui benjycui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yiminghe @benjycui