-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack 3 #60
Conversation
yesmeck
commented
Oct 11, 2017
•
edited
edited
- remove atool-build
- webpack 3
- babel-preset-env
- upgrade all denpendencies
return require.resolve(`babel-preset-${name}`); | ||
})), | ||
presets: [ | ||
require.resolve('babel-preset-react'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个好像不需要也可以的。。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
要的吧,哪个里包含这个了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bisheng 没加也可以正常工作 https://github.com/benjycui/bisheng/blob/master/packages/bisheng/src/config/getBabelCommonConfig.js
先删除试试?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
试了下是需要的。
lib/gulpfile.js
Outdated
@@ -31,18 +32,31 @@ const libDir = path.join(cwd, 'lib'); | |||
const esDir = path.join(cwd, 'es'); | |||
|
|||
function dist(done) { | |||
console.log(require.resolve('webpack')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug 代码删除下?