Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): EditableTable support max length #1286

Merged
merged 1 commit into from Dec 12, 2020
Merged

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Dec 12, 2020

close #1218

@github-actions
Copy link

github-actions bot commented Dec 12, 2020

🎊 PR Preview 5c891c9 has been successfully built and deployed to https://ant-design-pro-components-preview-pr-1286.surge.sh

🕐 Build time: 478.629s

🤖 By surge-preview

@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #1286 (5c891c9) into master (bc8821b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1286   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files         148      148           
  Lines        4103     4107    +4     
  Branches     1486     1488    +2     
=======================================
+ Hits         3991     3995    +4     
  Misses        108      108           
  Partials        4        4           
Impacted Files Coverage Δ
packages/table/src/EditableTable.tsx 90.90% <100.00%> (+1.25%) ⬆️
packages/utils/src/useEditableArray/index.tsx 100.00% <100.00%> (ø)
packages/utils/src/useEditableMap/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8821b...5c891c9. Read the comment docs.

@github-actions
Copy link

size-limit report

Path Size
packages/card/dist/card.js 20.79 KB (0%)
packages/descriptions/dist/descriptions.js 23.92 KB (0%)
packages/field/dist/field.js 45.53 KB (0%)
packages/form/dist/form.js 52.41 KB (0%)
packages/layout/dist/layout.js 114.67 KB (0%)
packages/list/dist/list.js 197.28 KB (0%)
packages/provider/dist/provider.js 8.25 KB (0%)
packages/skeleton/dist/skeleton.js 15.01 KB (0%)
packages/table/dist/table.js 86.71 KB (+0.08% 🔺)

@chenshuai2144 chenshuai2144 merged commit dac9844 into master Dec 12, 2020
@chenshuai2144 chenshuai2144 deleted the max-lenght branch December 12, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👑 [需求]ProTable 的Editable能否控制添加行数的最大数量
1 participant