New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(table): remove unnecessary tooltip #1907
Conversation
写的有点复杂,我有些看不懂 |
我描述的可能有点不太清晰。 |
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
==========================================
- Coverage 99.04% 99.04% -0.01%
==========================================
Files 159 159
Lines 4723 4718 -5
Branches 1701 1699 -2
==========================================
- Hits 4678 4673 -5
Misses 44 44
Partials 1 1
Continue to review full report at Codecov.
|
修改的代码是利用了 Typography.Text 组件的 ellipsis 属性展示对应的 tooltip,没有再额外使用 Tooltip 组件进行包裹。 |
Merge下主分支吧 |
嗯,已经 Merge 好了 |
测试覆盖率低了一点,搞个测试用例覆盖一下吧 |
修改了一下,之前测试覆盖率低是因为没有覆盖到 genEllipsis 函数。 |
issue:ProTable Column 中未进行缩略的内容不需要展示 Tooltip #1906