Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): fix polling alway run after unmount table #2308

Merged
merged 1 commit into from Mar 25, 2021

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Mar 25, 2021

close #2304

@github-actions
Copy link

github-actions bot commented Mar 25, 2021

😭 Deploy PR Preview b168552 failed. Build logs

🤖 By surge-preview

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2308 (b168552) into master (65f0e4c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2308   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         169      169           
  Lines        5007     5009    +2     
  Branches     1790     1790           
=======================================
+ Hits         4964     4966    +2     
  Misses         42       42           
  Partials        1        1           
Impacted Files Coverage Δ
packages/field/src/components/Progress/index.tsx 96.29% <100.00%> (ø)
packages/table/src/useFetchData.tsx 99.05% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f0e4c...b168552. Read the comment docs.

@github-actions
Copy link

size-limit report

Path Size
packages/card/dist/card.js 18.92 KB (0%)
packages/descriptions/dist/descriptions.js 20.53 KB (0%)
packages/field/dist/field.js 132.78 KB (-0.02% 🔽)
packages/form/dist/form.js 56.97 KB (0%)
packages/layout/dist/layout.js 76.56 KB (0%)
packages/list/dist/list.js 142.08 KB (0%)
packages/provider/dist/provider.js 11.37 KB (0%)
packages/skeleton/dist/skeleton.js 5.19 KB (0%)
packages/table/dist/table.js 48.11 KB (+0.11% 🔺)

@chenshuai2144 chenshuai2144 merged commit f23bb96 into master Mar 25, 2021
@chenshuai2144 chenshuai2144 deleted the fix-polling branch March 25, 2021 04:03
@chenshuai2144 chenshuai2144 restored the fix-polling branch March 29, 2021 03:35
@chenshuai2144 chenshuai2144 deleted the fix-polling branch March 29, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛[BUG] 组件卸载后 轮询并没有停止
1 participant