fix(form): 当设置了digit的stringMode为true，但是组件没有返回string #7031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview has been successfully built and deployed to https://pro-components-preview-pr-7031.surge.sh
|
chenshuai2144
changed the title
|
stringMode 是谁提供的功能？ antd？ |
|
|
修复下测试用例？ |
ldwonday
force-pushed
the
fix/digit_stringmode
branch
3 times, most recently
from
b20ccec
to
2c06716
Compare
|
用例已修复，但是这个流水线一直报错不知道啥问题 |
|
再 merge 一下 master |
ldwonday
force-pushed
the
fix/digit_stringmode
branch
from
2c06716
to
36010b0
Compare
|
done |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7031 +/- ##
==========================================
- Coverage 97.73% 97.72% -0.01%
==========================================
Files 338 338
Lines 10980 10980
Branches 3940 3940
==========================================
- Hits 10731 10730 -1
- Misses 206 207 +1
Partials 43 43
☔ View full report in Codecov by Sentry. |
jddxf
reviewed
Oct 7, 2023
| @@ -32,7 +32,7 @@ const FieldDigit: ProFieldFC<FieldDigitProps> = ( | |||
| (value: number | string | null) => { | |||
| let val = value ?? undefined; | |||
|
|
|||
| if (typeof val === 'string') { | |||
| if (!fieldProps.stringMode && typeof val === 'string') { | |||
There was a problem hiding this comment.
这么改 stringMode 时就不会处理 precision 了吧，是不是应该把类型处理放在最后？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.