Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form):Create resizable drawer #7288

Merged
merged 17 commits into from
Jul 17, 2023
Merged

Conversation

natashaamin
Copy link
Contributor

@natashaamin natashaamin commented Jun 27, 2023

Screen.Recording.2023-06-27.at.11.53.54.AM.online-video-cutter.com.mp4

By adding new api called isResizable, user will be able to change the width of the drawer by dragging it. It gives a flexible way for user to have a better view of internal content.

Do let me know if there i any changes need to improve. I really appreciate the afford to review it. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

😭 Deploy PR Preview failed.

@chenshuai2144 chenshuai2144 changed the title Create resizable drawer feat(form):Create resizable drawer Jun 29, 2023
@chenshuai2144
Copy link
Contributor

我对 api 有一些疑问,我觉得这样会好一些

resize={{
   onResize:(size)=>{}
}}

resize=false

resize={{}}

@natashaamin
Copy link
Contributor Author

我对 api 有一些疑问,我觉得这样会好一些

resize={{
   onResize:(size)=>{}
}}

resize=false

resize={{}}

do u still have a lot of keys inside resize? or is it only onResize?

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 63.15% and project coverage change: -0.18 ⚠️

Comparison is base (89e1fb4) 97.89% compared to head (466025a) 97.72%.

❗ Current head 466025a differs from pull request most recent head d8edc9b. Consider uploading reports for the commit d8edc9b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7288      +/-   ##
==========================================
- Coverage   97.89%   97.72%   -0.18%     
==========================================
  Files         338      339       +1     
  Lines       11282    11335      +53     
  Branches     4108     4125      +17     
==========================================
+ Hits        11045    11077      +32     
- Misses        198      219      +21     
  Partials       39       39              
Impacted Files Coverage Δ
packages/form/src/layouts/DrawerForm/index.tsx 84.55% <54.34%> (-15.45%) ⬇️
packages/field/src/components/Code/index.tsx 100.00% <100.00%> (ø)
packages/form/src/layouts/DrawerForm/style.ts 100.00% <100.00%> (ø)
packages/layout/src/ProLayout.tsx 97.81% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ONLY-yours
Copy link
Collaborator

Codecov Report

Patch coverage: 63.41% and project coverage change: -0.12 ⚠️

Comparison is base (da90c1a) 97.98% compared to head (ce5af9e) 97.86%.

❗ Current head ce5af9e differs from pull request most recent head e759a90. Consider uploading reports for the commit e759a90 to get more accurate results

Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Do you have feedback about the report comment? Let us know in this issue.

@natashaamin can you add some unit test about it, coverage was a little updown

@chenshuai2144
Copy link
Contributor

Currently, there is only 'onResize' available, but in the future, there might be additional features added, such as maximum width and minimum width.

@natashaamin

@natashaamin
Copy link
Contributor Author

Currently, there is only 'onResize' available, but in the future, there might be additional features added, such as maximum width and minimum width.

@natashaamin

Tried to do as what you suggestion. Can you help me take a look into it please? Thank you.

@chenshuai2144
Copy link
Contributor

👌

@chenshuai2144 chenshuai2144 merged commit 3f5cbe6 into ant-design:master Jul 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants