Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): 修复transform方法与文档用法预期不符 #7486

Merged
merged 2 commits into from
Aug 8, 2023
Merged

fix(form): 修复transform方法与文档用法预期不符 #7486

merged 2 commits into from
Aug 8, 2023

Conversation

xliez
Copy link
Contributor

@xliez xliez commented Aug 7, 2023

fix: #7483

有点担心是否会造成已经在将错就错得使用的代码引发问题😥

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

😭 Deploy PR Preview failed.

@xliez xliez changed the title fix(form): 修复transform方法与预期不符 fix(form): 修复transform方法与文档用法预期不符 Aug 7, 2023
@chenshuai2144
Copy link
Contributor

感觉会这样的,测试怎么挂了

@xliez
Copy link
Contributor Author

xliez commented Aug 8, 2023

coverage CI 我本地执行测试是通过的
Build CI tsc 不通过似乎是因为 Select 的 allowClear props 和 Input 的不一致导致的

@xliez
Copy link
Contributor Author

xliez commented Aug 8, 2023

重新执行了下测试用例,failed 的 case 还不一样了😥

@chenshuai2144
Copy link
Contributor

mege 一下 master

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (481d7a2) 98.31% compared to head (c4fc393) 98.32%.

❗ Current head c4fc393 differs from pull request most recent head c6d86f7. Consider uploading reports for the commit c6d86f7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7486   +/-   ##
=======================================
  Coverage   98.31%   98.32%           
=======================================
  Files         340      340           
  Lines       11366    11374    +8     
  Branches     4265     4268    +3     
=======================================
+ Hits        11175    11183    +8     
  Misses        150      150           
  Partials       41       41           
Files Changed Coverage Δ
...ackages/utils/src/transformKeySubmitValue/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenshuai2144 chenshuai2144 merged commit 240810d into ant-design:master Aug 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧐[问题] transform文档是不是有误
2 participants