Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sending request directly to the instance #192

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Conversation

mustafaboleken
Copy link
Contributor

@mustafaboleken
Copy link
Contributor Author

I delete this code section because it blocks the creation stream sources on other instances and I think we don't have to force users to use jwt filter.

@mekya
Copy link
Contributor

mekya commented Nov 21, 2022

Converting to HTTP may cause problem. I think this is the similar issue
ant-media/Ant-Media-Server#4579

@mustafaboleken
Copy link
Contributor Author

In the latest snaphost, it's solved. I can send request directly on ip address.

@mustafaboleken mustafaboleken changed the title Remove jwt filter check Remove sending request directly to the instance Nov 28, 2022
@@ -329,16 +329,6 @@ <h4 class="card-title text-left" i18n="@@newLiveStreamCardTitle">
</ng-container>
</div>

<div class="form-group text-left" *ngIf="isClusterMode">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we cannot show cluster IP addresses list, how can we send it to a specific cluster IP address? Moreover, I cannot see any IP address on the REST request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the cors error, people cannot use this feature. We will bring it back in the near future. We planned 3 stage for it.

This is the first phase actually.
The second phase is to make the default value of settings.streamFetcherAutoStart false.
For the third phase, we will develop another solution to create stream source for specific cluster IP address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants