Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MP4 and WebM record button in broadcast setting menu #88

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

SelimEmre
Copy link
Contributor

No description provided.

@mekya
Copy link
Contributor

mekya commented Aug 4, 2020

It seems there are two recordings button. One for mp4 and one for webm. It does not sound very good to me.
Because I don't have very clear recommendation for that for now. I don't make a Request Changes

@SelimEmre SelimEmre requested a review from mekya August 7, 2020 17:13
@mekya mekya merged commit 33e4ed1 into master Aug 10, 2020
@mekya mekya deleted the feature/add-record-button branch August 10, 2020 08:21
@Glfarley
Copy link

I am a bit confused. There seem to be two different features discussed here. One is to choose between recording in mp4 or webm format in the broadcast settingscreen of the web dashboard. The other (the one I requested) is a button to start recording a particular stream in the Live Streams screen of the web dashboard. Is this correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants