-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webrtc_adaptor.js as npm package #2504
Comments
Update JS SDK about this package |
Hi, StreamApp repo is automated with an npm git package, the package can be installed via:
The package is on: https://github.com/ant-media/StreamApp/packages/788162 @mekya after we merge the pull request, any commits merged with master will update the version of npm package automatically: The one thing customers should keep in mind is that this is an npm git registry package rather than a pure npm package because of the github origin and automation, therefore in their ~/.npmrc file, they need to authenticate git as adding the line: //npm.pkg.github.com/:_authToken={ Personal auth token from github } To get personal access token from github for the people who doesn't use it in a detailed explanation: Cheers |
Thank you for your work @golgetahir I've added some comments in PR |
I've merged it with master. The version always seem to be 1.2.0? |
Hello @golgetahir, I'm trying to use the npm package published at https://www.npmjs.com/package/@antmedia/webrtc_adaptor. However, I can't use it as is for the moment because the entry point is I also noticed that the npm package name is Thanks ! |
Hi @guiyom-e We were using the github registry of npm npm.pkg.github.com because of the release automation and publish synchronization with workflows, however, some of the users couldn't download it from the github registry of npm like in the above comment of mine, so we have published also to the npm registry as a second package. You are right, I will update the package entry point as you suggested. Thanks for the notification. Cheers |
Hello 👋 Do you know, when the |
Let us put back to the |
Hi @guiyom-e @AlexandreBourdeaudhui , v2.4.3 is being published to the https://www.npmjs.com/@antmedia/webrtc_adaptor We've also fixed the publish automation so releases will be sent to npmjs automatically when there is a new release. |
Btw, we've also created an issue to prepare doc for webrtc_adaptor FYI |
Hello @mekya, thanks for your feedback, and thanks for the publish 🙏 |
My pleasure. Thank you for your patience. Regards, |
Being able to reach webrtc_adaptor.js as an npm package would be more convenient for users.
The text was updated successfully, but these errors were encountered: