Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webrtc_adaptor.js as npm package #2504

Closed
golgetahir opened this issue Sep 15, 2020 · 13 comments
Closed

Add webrtc_adaptor.js as npm package #2504

golgetahir opened this issue Sep 15, 2020 · 13 comments
Assignees

Comments

@golgetahir
Copy link
Contributor

Being able to reach webrtc_adaptor.js as an npm package would be more convenient for users.

@mekya
Copy link
Contributor

mekya commented May 10, 2021

Update JS SDK about this package

@golgetahir
Copy link
Contributor Author

Hi,

StreamApp repo is automated with an npm git package, the package can be installed via:

npm install @ant-media/streamapp@1.1.0

The package is on:

https://github.com/ant-media/StreamApp/packages/788162

@mekya after we merge the pull request, any commits merged with master will update the version of npm package automatically:
ant-media/StreamApp#164

The one thing customers should keep in mind is that this is an npm git registry package rather than a pure npm package because of the github origin and automation, therefore in their ~/.npmrc file, they need to authenticate git as adding the line:

//npm.pkg.github.com/:_authToken={ Personal auth token from github }

To get personal access token from github for the people who doesn't use it in a detailed explanation:
https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-npm-registry#authenticating-to-github-packages

Cheers

@mekya
Copy link
Contributor

mekya commented May 24, 2021

Thank you for your work @golgetahir

I've added some comments in PR
ant-media/StreamApp#164 (review)

@mekya
Copy link
Contributor

mekya commented Jun 6, 2021

I've merged it with master. The version always seem to be 1.2.0?

@golgetahir
Copy link
Contributor Author

ant-media/StreamApp#176

@guiyom-e
Copy link

Hello @golgetahir,

I'm trying to use the npm package published at https://www.npmjs.com/package/@antmedia/webrtc_adaptor.

However, I can't use it as is for the moment because the entry point is "main": "index.html", but it should be "main": "js/webrtc_adaptor.js" like on the github package.json. Is it planned to be changed ?

I also noticed that the npm package name is @antmedia/webrtc_adaptor and not @ant-media/webrtc_adaptor as defined in the doc. Is it a typo or done on purpose ?

Thanks !

@golgetahir
Copy link
Contributor Author

golgetahir commented Dec 28, 2021

Hi @guiyom-e

We were using the github registry of npm npm.pkg.github.com because of the release automation and publish synchronization with workflows, however, some of the users couldn't download it from the github registry of npm like in the above comment of mine, so we have published also to the npm registry as a second package. You are right, I will update the package entry point as you suggested. Thanks for the notification.

Cheers

@AlexandreBourdeaudhui
Copy link

Hello 👋 Do you know, when the 2.4.3 version will be published on NPM / GitHub registry ?
Best regards

@mekya
Copy link
Contributor

mekya commented Jun 2, 2022

Let us put back to the In Progress pipeline to make this work automatically.

@mekya mekya assigned mekya and unassigned golgetahir Jun 6, 2022
@mekya
Copy link
Contributor

mekya commented Jun 14, 2022

Hi @guiyom-e @AlexandreBourdeaudhui ,

v2.4.3 is being published to the https://www.npmjs.com/@antmedia/webrtc_adaptor

We've also fixed the publish automation so releases will be sent to npmjs automatically when there is a new release.

@mekya
Copy link
Contributor

mekya commented Jun 14, 2022

Btw, we've also created an issue to prepare doc for webrtc_adaptor
#4243

FYI

@AlexandreBourdeaudhui
Copy link

Hello @mekya, thanks for your feedback, and thanks for the publish 🙏
Have a great day!

@mekya
Copy link
Contributor

mekya commented Jun 15, 2022

My pleasure. Thank you for your patience.

Regards,
A. Oguz

@mekya mekya closed this as completed Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants