Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to turn off console.log statements in videojs-webrtc-plugin #5174

Closed
wheelbarrow777 opened this issue Jun 1, 2023 · 3 comments · Fixed by ant-media/StreamApp#381
Closed
Assignees

Comments

@wheelbarrow777
Copy link

Is your feature request related to a problem? Please describe.
When using @antmedia/videojs-webrtc-plugin, especially the main branch, there is a lot of console.log statements. This clutters the console and it's often preferable to turn it off.

Describe the solution you'd like
Add a log level option to allow for disabling console.log statements in production.

Describe alternatives you've considered
Fork the repository and remove all console.log statements.

Additional context

@mustafaboleken
Copy link
Contributor

Hi @wheelbarrow777

I hope you are doing well. Currently, I'm working on this issue. To be on the same page, did you talk about the following logs?

Image

@wheelbarrow777
Copy link
Author

Hi @wheelbarrow777

I hope you are doing well. Currently, I'm working on this issue. To be on the same page, did you talk about the following logs?

Image

Correct, those are the logs I'm talking about.

@mekya
Copy link
Contributor

mekya commented Jun 12, 2023

Hi @wheelbarrow777,

The PR has been merged. Thank you to @mustafaboleken for his good work.

Default loglevel is warning.

You can change log level with string parameter(lowercase or uppercase)

window.log.setLevel("trace");

or integer parameter

window.log.setLevel(0);

Here are the levels

"TRACE": 0,
"DEBUG": 1,
"INFO": 2,
"WARN": 3,
"ERROR": 4,
"SILENT": 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants