Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket signaling ping/pong request #718

Closed
Stinkie opened this issue Dec 18, 2018 · 5 comments
Closed

Websocket signaling ping/pong request #718

Stinkie opened this issue Dec 18, 2018 · 5 comments
Assignees

Comments

@Stinkie
Copy link

Stinkie commented Dec 18, 2018

In order to avoid websocket connection drop by network devices and to have a better check if connection is really alive we'd like to introduce 'ping' request. Simple response to it should be 'pong'

@mekya
Copy link
Contributor

mekya commented Dec 18, 2018

This is a simple client side to check connection is alive

@Stinkie
Copy link
Author

Stinkie commented Dec 18, 2018

currently if we send it - respose is smth like 'not supported method'. This is fine for now as it's basically the same. Reponding 'pong' is just more logical

@The-Code-Monkey
Copy link

@Stinkie how did you get it to do this as im getting the ws dropping out but it wont respond to me sending ping to it

@SelimEmre
Copy link
Contributor

@The-Code-Monkey
Copy link

I am sending the ping command through @SelimEmre and its not returning the pong command has this feature been removed??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants