Update_vod_transcode_script #206

muratugureminoglu · 2023-01-09T10:21:05Z

ant-media/Ant-Media-Server#4684

mekya

I request some improvements. Thank you for your work.

vod_transcode.sh

sonatype-lift · 2023-02-01T15:14:21Z

vod_transcode.sh

@@ -23,7 +23,10 @@ b=("640x480" "1500k")
 # 240p
 c=("320x240" "800k")

+cd ${file%/*}/


SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-01T15:14:23Z

vod_transcode.sh

@@ -23,7 +23,10 @@ b=("640x480" "1500k")
 # 240p
 c=("320x240" "800k")

+cd ${file%/*}/


SC2086: Double quote to prevent globbing and word splitting.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-05T21:12:03Z

vod_transcode.sh

SC2128: Expanding an array without an index only gives the first element.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-05T21:12:05Z

vod_transcode.sh

+if [ ! -z $a ]; then
+	$(command -v ffmpeg) -i $file -crf 27 -preset veryfast -map 0:v:0 -map 0:a:0 -map 0:v:0 -map 0:a:0 -map 0:v:0 -map 0:a:0 -s:v:0 ${a[0]} -c:v:0 libx264 -b:v:0 ${a[1]} -c:a aac -f hls -hls_playlist_type vod -master_pl_name ${file_name}.m3u8 -hls_segment_filename ${file_name}_%v/${file_name}%03d.ts -use_localtime_mkdir 1 -var_stream_map "v:0,a:0,name:720p" ${file_name}_%v.m3u
+elif [ ! -z $b ]; then


SC2128: Expanding an array without an index only gives the first element.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-05T21:12:06Z

vod_transcode.sh

+	$(command -v ffmpeg) -i $file -crf 27 -preset veryfast -map 0:v:0 -map 0:a:0 -map 0:v:0 -map 0:a:0 -map 0:v:0 -map 0:a:0 -s:v:1 ${b[0]} -c:v:1 libx264 -b:v:1 ${b[1]} -c:a aac -f hls -hls_playlist_type vod -master_pl_name ${file_name}.m3u8 -hls_segment_filename ${file_name}_%v/${file_name}%03d.ts -use_localtime_mkdir 1 -var_stream_map "v:1,a:1,name:480p" ${file_name}_%v.m3u
+elif [ ! -z $a ] && [ ! -z $b ]; then
+	$(command -v ffmpeg) -i $file -crf 27 -preset veryfast -map 0:v:0 -map 0:a:0 -map 0:v:0 -map 0:a:0 -map 0:v:0 -map 0:a:0 -s:v:0 ${a[0]} -c:v:0 libx264 -b:v:0 ${a[1]} -s:v:1 ${b[0]} -c:v:1 libx264 -b:v:1 ${b[1]} -s:v:2 ${c[0]} -c:v:2 libx264 -b:v:2 ${c[1]} -c:a aac -f hls -hls_playlist_type vod -master_pl_name ${file_name}.m3u8 -hls_segment_filename ${file_name}_%v/${file_name}%03d.ts -use_localtime_mkdir 1 -var_stream_map "v:0,a:0,name:720p v:1,a:1,name:480p" ${file_name}_%v.m3u


SC2154: c is referenced but not assigned.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-05T21:12:08Z

vod_transcode.sh

💬 3 similar findings have been found in this PR

SC2236: Use -n instead of ! -z.

🔎 Expand here to view all instances of this finding

File Path Line Number

vod_transcode.sh 33

vod_transcode.sh 35

vod_transcode.sh 35

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-02-05T21:12:10Z

vod_transcode.sh

💬 3 similar findings have been found in this PR

SC2086: Double quote to prevent globbing and word splitting.

🔎 Expand here to view all instances of this finding

File Path Line Number

vod_transcode.sh 33

vod_transcode.sh 35

vod_transcode.sh 35

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

mekya

Please take a look at the comments

mekya · 2023-02-13T05:45:31Z

vod_transcode.sh

If b and c is defined, it still enters this if statement

mekya · 2023-02-13T05:46:37Z

vod_transcode.sh

+	$(command -v ffmpeg) -i $file -crf 27 -preset veryfast -map 0:v:0 -map 0:a:0 -map 0:v:0 -map 0:a:0 -map 0:v:0 -map 0:a:0 -s:v:0 ${a[0]} -c:v:0 libx264 -b:v:0 ${a[1]} -s:v:1 ${b[0]} -c:v:1 libx264 -b:v:1 ${b[1]} -s:v:2 ${c[0]} -c:v:2 libx264 -b:v:2 ${c[1]} -c:a aac -f hls -hls_playlist_type vod -master_pl_name ${file_name}.m3u8 -hls_segment_filename ${file_name}_%v/${file_name}%03d.ts -use_localtime_mkdir 1 -var_stream_map "v:0,a:0,name:720p v:1,a:1,name:480p" ${file_name}_%v.m3u
+else
+	$(command -v ffmpeg) -i $file -codec copy -hls_segment_filename ${file_name}_%v/${file_name}%03d.ts -use_localtime_mkdir 1 ${file_name}.m3u8


use_localtime_mkdir is not available in ffmpeg 5.1.2, use strftime_mkdir

mekya · 2023-02-13T05:47:50Z

vod_transcode.sh

+	$(command -v ffmpeg) -i $file -crf 27 -preset veryfast -map 0:v:0 -map 0:a:0 -map 0:v:0 -map 0:a:0 -map 0:v:0 -map 0:a:0 -s:v:0 ${a[0]} -c:v:0 libx264 -b:v:0 ${a[1]} -s:v:1 ${b[0]} -c:v:1 libx264 -b:v:1 ${b[1]} -s:v:2 ${c[0]} -c:v:2 libx264 -b:v:2 ${c[1]} -c:a aac -f hls -hls_playlist_type vod -master_pl_name ${file_name}.m3u8 -hls_segment_filename ${file_name}_%v/${file_name}%03d.ts -use_localtime_mkdir 1 -var_stream_map "v:0,a:0,name:720p v:1,a:1,name:480p" ${file_name}_%v.m3u
+else
+	$(command -v ffmpeg) -i $file -codec copy -hls_segment_filename ${file_name}_%v/${file_name}%03d.ts -use_localtime_mkdir 1 ${file_name}.m3u8


Need to use -hls_playlist_type vod to keep all files in the list. Otherwise it just keeps last 5 files

Update_vod_transcode_script

126882f

asharamseervi mentioned this pull request Jan 21, 2023

VOD video is distorted after transcoding ant-media/Ant-Media-Server#4684

Open

mekya requested changes Jan 30, 2023

View reviewed changes

vod_transcode.sh Outdated Show resolved Hide resolved

vod_transcode.sh Outdated Show resolved Hide resolved

vod_transcode.sh Outdated Show resolved Hide resolved

vod_transcode.sh Outdated Show resolved Hide resolved

Remove -preset and -crf parameters

768f9fc

sonatype-lift bot reviewed Jan 30, 2023

View reviewed changes

vod_transcode.sh Outdated Show resolved Hide resolved

Remove specific file path

887c975

sonatype-lift bot reviewed Feb 1, 2023

View reviewed changes

Update the script

381d738

sonatype-lift bot reviewed Feb 5, 2023

View reviewed changes

mekya requested changes Feb 13, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update_vod_transcode_script #206

Update_vod_transcode_script #206

muratugureminoglu commented Jan 9, 2023 •

edited by mekya

mekya left a comment

sonatype-lift bot Feb 1, 2023

sonatype-lift bot Feb 1, 2023

sonatype-lift bot Feb 5, 2023

sonatype-lift bot Feb 5, 2023

sonatype-lift bot Feb 5, 2023

sonatype-lift bot Feb 5, 2023

sonatype-lift bot Feb 5, 2023

mekya left a comment

mekya Feb 13, 2023

mekya Feb 13, 2023

mekya Feb 13, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

Update_vod_transcode_script #206

Are you sure you want to change the base?

Update_vod_transcode_script #206

Conversation

muratugureminoglu commented Jan 9, 2023 • edited by mekya

mekya left a comment

Choose a reason for hiding this comment

sonatype-lift bot Feb 1, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 1, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 5, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 5, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 5, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 5, 2023

Choose a reason for hiding this comment

sonatype-lift bot Feb 5, 2023

Choose a reason for hiding this comment

mekya left a comment

Choose a reason for hiding this comment

mekya Feb 13, 2023

Choose a reason for hiding this comment

mekya Feb 13, 2023

Choose a reason for hiding this comment

mekya Feb 13, 2023

Choose a reason for hiding this comment

muratugureminoglu commented Jan 9, 2023 •

edited by mekya