Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable echo cancellation and noise suppression in default #351

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Disable echo cancellation and noise suppression in default #351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6004d99
Close echoCancellation and noiseSuppression in default
mustafaboleken Apr 2, 2023
2557f8d
Merge remote-tracking branch 'origin/master' into fix/issue-4837
mekya Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/main/webapp/samples/publish_webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@
<legend class="col-form-label audio-quality-legend">Audio Quality</legend>
<div class="form-check-inline form-inline">
<div class="custom-control custom-switch">
<input type="checkbox" class="custom-control-input" name="noiseSuppression" checked
<input type="checkbox" class="custom-control-input" name="noiseSuppression"
id="noiseSuppression">
<label class="custom-control-label" for="noiseSuppression">Noise Supression</label>
</div>
</div>
<div class="form-check-inline form-inline">
<div class="custom-control custom-switch">
<input type="checkbox" class="custom-control-input" name="echoCancellation" checked
<input type="checkbox" class="custom-control-input" name="echoCancellation"
id="echoCancellation">
<label class="custom-control-label" for="echoCancellation">Echo Cancellation</label>
</div>
Expand Down Expand Up @@ -159,6 +159,15 @@
debug = false;
}

var mediaConstraints = {
audio: {
noiseSuppression: false,
echoCancellation: false
},
video: true
};


function init() {
$('[data-toggle="tooltip"]').tooltip()
var id = getUrlParameter("id");
Expand Down Expand Up @@ -511,6 +520,7 @@
websocket_url: websocketURL,
localVideoId: "localVideo",
debug: debug,
mediaConstraints: mediaConstraints,
bandwidth: maxVideoBitrateKbps,
dataChannelEnabled: true,
callback: (info, obj) => {
Expand Down