fix video elements not getting removed when leaving room #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 37.41% 37.41%
=======================================
Files 7 7
Lines 1708 1708
=======================================
Hits 639 639
Misses 1069 1069 ☔ View full report in Codecov by Sentry. |
|
Thank you @USAMAWIZARD for the fix. Sometimes event.track.id can come as null or undefined as far as I remember. Anyway, let me merge it and let's write some interagtion test codes for conferencing. |
mekya
approved these changes
Jun 22, 2023
|
Okay Got it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-media/Ant-Media-Server#5281