Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type definition to media constraints #430

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Add type definition to media constraints #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de4d0ab
Change parameter type of openStream
mustafaboleken Jan 22, 2024
a5832e6
Add type into media constraints
mustafaboleken Jan 22, 2024
f65b8fb
Update webrtc_adaptor.js
mustafaboleken Jan 22, 2024
464f915
Merge branch 'master' into fix/issue-6045
mustafaboleken Mar 8, 2024
b6a8fd3
Merge branch 'master' into fix/issue-6045
mustafaboleken Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/js/media_manager.js
View file
Open in desktop
Expand Up @@ -43,9 +43,12 @@ export class MediaManager {

/**
* initial media constraints provided by the user
* @type {MediaStreamConstraints}
*/
this.mediaConstraints = {
/** @type {MediaTrackConstraints} */
video: true,
/** @type {MediaTrackConstraints} */
audio: true
};
;
Expand Down
2 changes: 1 addition & 1 deletion src/main/js/webrtc_adaptor.js
View file
Open in desktop
Expand Up @@ -2186,7 +2186,7 @@ export class WebRTCAdaptor {
}
/**
*
* @param {object} mediaConstraints : media constraints to be used for opening the stream
* @param {MediaStreamConstraints} mediaConstraints : media constraints to be used for opening the stream
* @param {string} streamId : id of the stream to replace tracks with
* @returns
*/
Expand Down