Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalised 1.1.x Release #13

Merged
merged 93 commits into from
Nov 28, 2023
Merged

Finalised 1.1.x Release #13

merged 93 commits into from
Nov 28, 2023

Conversation

hjabbot
Copy link
Collaborator

@hjabbot hjabbot commented Oct 28, 2023

CartograPhi/MeshiPhi Pull Request 13

Date: 2023-10-28
Version Number: 1.1.5

Description of change

Merging next major release into main and changing repo name from CartograPhi to MeshiPhi

Testing

To ensure that the functionality of the CartograPhi codebase remains consistent throughout the development cycle a testing strategy has been developed, which can be viewed in the document test/testing_strategy.md.
This includes a collection of test files which should be run according to which part of the codebase has been altered in a pull request. Please consult the testing strategy to determine which tests need to be run.

  • My changes have not altered any of the files listed in the testing strategy

  • My changes result in all required regression tests passing without the need to update test files.

  • My changes require one or more test files to be updated for all regression tests to pass.

Changed in prior PR's, won't reiterate here
Passing reg tests
1 Warning appears now, Deprecation Warning from the re package.

Checklist

  • My code follows pep8 style guidelines.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation of the codebase where required.
  • My changes generate no new warnings.
  • My PR has been made to the 1.1.x branch (DO NOT SUBMIT A PR TO MAIN)

hjabbot and others added 30 commits August 24, 2023 14:36
Updating 1.1.x from main
Copy link
Member

@gecoombs gecoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

Copy link
Collaborator

@SamuelHall700 SamuelHall700 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@gecoombs gecoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just took a look at the docs after going over them for PolarRoute. I noticed that the html files haven't been rebuilt so I tried running sphinx-build. When I do that it gives me the following warnings:

reading sources... [100%] index
/home/gecoomb/PycharmProjects/CartograPhi/docs/source/index.rst:19: WARNING: toctree contains reference to nonexisting document 'sections/Plotting'
looking for now-outdated files... none found
pickling environment... done
checking consistency... /home/gecoomb/PycharmProjects/CartograPhi/docs/source/sections/Plotting/mesh_plotting.rst: WARNING: document isn't included in any toctree
done
preparing documents... done
copying assets... copying static files... done
copying extra files... done
done
writing output... [100%] index
/home/gecoomb/PycharmProjects/CartograPhi/docs/source/index.rst:4: WARNING: undefined label: 'mesh_plotting'

These seem to be related to the plotting section you added @SamuelHall700 could you take a look and see if you can work out how to fix this?

@gecoombs gecoombs merged commit eea0e5b into main Nov 28, 2023
@gecoombs gecoombs mentioned this pull request Feb 13, 2024
8 tasks
@SamuelHall700 SamuelHall700 deleted the 1.1.x branch March 5, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants