-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalised 1.1.x Release #13
Conversation
Updating 1.1.x from main
…into pipeline_fixes
…hi into pipeline_fixes
Pipeline fixes
Meshi phi rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just took a look at the docs after going over them for PolarRoute. I noticed that the html files haven't been rebuilt so I tried running sphinx-build
. When I do that it gives me the following warnings:
reading sources... [100%] index
/home/gecoomb/PycharmProjects/CartograPhi/docs/source/index.rst:19: WARNING: toctree contains reference to nonexisting document 'sections/Plotting'
looking for now-outdated files... none found
pickling environment... done
checking consistency... /home/gecoomb/PycharmProjects/CartograPhi/docs/source/sections/Plotting/mesh_plotting.rst: WARNING: document isn't included in any toctree
done
preparing documents... done
copying assets... copying static files... done
copying extra files... done
done
writing output... [100%] index
/home/gecoomb/PycharmProjects/CartograPhi/docs/source/index.rst:4: WARNING: undefined label: 'mesh_plotting'
These seem to be related to the plotting section you added @SamuelHall700 could you take a look and see if you can work out how to fix this?
CartograPhi/MeshiPhi Pull Request 13
Date: 2023-10-28
Version Number: 1.1.5
Description of change
Merging next major release into main and changing repo name from CartograPhi to MeshiPhi
Testing
To ensure that the functionality of the CartograPhi codebase remains consistent throughout the development cycle a testing strategy has been developed, which can be viewed in the document
test/testing_strategy.md
.This includes a collection of test files which should be run according to which part of the codebase has been altered in a pull request. Please consult the testing strategy to determine which tests need to be run.
My changes have not altered any of the files listed in the testing strategy
My changes result in all required regression tests passing without the need to update test files.
My changes require one or more test files to be updated for all regression tests to pass.
Checklist
1.1.x
branch (DO NOT SUBMIT A PR TO MAIN)