Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: pick shape with correct id from generator #84

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

FIX: pick shape with correct id from generator #84

wants to merge 9 commits into from

Conversation

kmuehlbauer
Copy link
Collaborator

closes #79

antarcticrainforest
antarcticrainforest requested changes Jul 6, 2023
View reviewed changes
Copy link
Owner

@antarcticrainforest antarcticrainforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this so quickly, you are a legend! I only have some minor comments!

src/tintx/objects.py Outdated Show resolved Hide resolved
@antarcticrainforest antarcticrainforest added bug Something isn't working invalid This doesn't seem right and removed invalid This doesn't seem right labels Jul 6, 2023
kmuehlbauer and others added 2 commits July 6, 2023 14:41
@kmuehlbauer @antarcticrainforest
Update src/tintx/objects.py
b8bde09 
Co-authored-by: Martin Bergemann <martin.bergemann@posteo.org>
@kmuehlbauer
FIX: styling
b8c12fc
@kmuehlbauer
Copy link
Collaborator Author

@antarcticrainforest No idea why the lint and style checks break. They shouldn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antarcticrainforest antarcticrainforest antarcticrainforest requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@kmuehlbauer kmuehlbauer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polygons sometimes inverted
2 participants
@kmuehlbauer @antarcticrainforest