Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement matches XPath function. #58

Merged
merged 4 commits into from
Nov 22, 2020
Merged

Implement matches XPath function. #58

merged 4 commits into from
Nov 22, 2020

Conversation

jf-tech
Copy link
Contributor

@jf-tech jf-tech commented Nov 22, 2020

See details in #57.

Also created a number of assert???? helpers in assert_test.go and moved assertPanic into it.

See details in #57.

Also created a number of `assert????` helpers in `assert_test.go` and moved `assertPanic` into it.
@coveralls
Copy link

coveralls commented Nov 22, 2020

Coverage Status

Coverage increased (+0.9%) to 76.813% when pulling e66c45d on jf-tech:matches into a5d9242 on antchfx:master.

@zhengchun zhengchun merged commit cd2afb8 into antchfx:master Nov 22, 2020
@zhengchun
Copy link
Contributor

Merged, Thanks!

@jf-tech jf-tech deleted the matches branch November 22, 2020 17:01
@jf-tech
Copy link
Contributor Author

jf-tech commented Nov 22, 2020

@zhengchun not very urgent, when you will cut a release?

@zhengchun
Copy link
Contributor

Now, Just waiting for travis-ci checking to passed.

@zhengchun
Copy link
Contributor

@jf-tech
Copy link
Contributor Author

jf-tech commented Nov 22, 2020

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants