Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug_backtrace argument type #90

Merged
merged 2 commits into from Aug 18, 2019
Merged

Fix debug_backtrace argument type #90

merged 2 commits into from Aug 18, 2019

Conversation

Stadly
Copy link
Contributor

@Stadly Stadly commented Nov 28, 2018

When patching a function defined inside a file with declare(strict_types=1);, the following exception is thrown on the line with the opening brace of the function:

TypeError: debug_backtrace() expects parameter 1 to be integer, boolean given

This pull request fixes the issue by changing the argument to the correct type. The type was changed from bool to int in PHP 5.3.6. This fix also works for older versions of PHP, since declare(strict_types=1); was introduced in PHP 7.

@widoz
Copy link

widoz commented Jul 31, 2019

Is there a way to push this forward?

@antecedent antecedent merged commit 04a0a97 into antecedent:master Aug 18, 2019
@Stadly Stadly deleted the patch-1 branch August 19, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants