Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pollutes global scope with Module #67

Open
davidyuk opened this issue Jun 5, 2021 · 2 comments · May be fixed by #78
Open

Pollutes global scope with Module #67

davidyuk opened this issue Jun 5, 2021 · 2 comments · May be fixed by #78

Comments

@davidyuk
Copy link

davidyuk commented Jun 5, 2021

Running hash defines a global variable Module with some internal stuff. Probably this comes from emscripten but would be better to avoid this, because of:

  • possible collision that may happen (also may be fixed by changing Module to something more specific)
  • to don't expose library internals without reason
  • in general, to don't define/change global variables should be a good practice
@antelle
Copy link
Owner

antelle commented Jun 5, 2021

I don't think it will be possible to solve this without changing how it works inside emscripten. Not closing for visibility, no action will be taken.

@antelle
Copy link
Owner

antelle commented Jun 5, 2021

Actually, I'm wrong, it's possible to change it: https://stackoverflow.com/questions/30152622/changing-the-default-namespace-module-in-emscripten

@davidyuk davidyuk linked a pull request Feb 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants