Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2 -> 4.0] TraceAPI: Correctly convert return value via ABI #2247

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Feb 20, 2024

  • Use action result type ABI for action return value conversion by ABI.
  • Only attempt conversion if an action return value ABI is available.
  • Updated tests to verify action return value handling.

Note: No replay of data is needed. trace_api_plugin was storing the data correctly on disk.

Merges release/3.0 into release/4.0 including #2246

Resolves #2228

@heifner heifner added the OCI Work exclusive to OCI team label Feb 20, 2024
@heifner heifner linked an issue Feb 20, 2024 that may be closed by this pull request
@heifner heifner added this to the Leap v4.0.6 milestone Feb 20, 2024
@heifner heifner merged commit 3864468 into release/4.0 Feb 20, 2024
16 checks passed
@heifner heifner deleted the GH-2228-return-value-4.0 branch February 20, 2024 19:46
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: BUG
summary: Correctly convert return value via ABI, allowing binary to variant conversation without crashing.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_binary_to_variant function crashing on some blocks
4 participants