Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0 -> main] TraceAPI: Correctly convert return value via ABI #2249

Merged
merged 9 commits into from
Feb 20, 2024
Merged

[5.0 -> main] TraceAPI: Correctly convert return value via ABI #2249

merged 9 commits into from
Feb 20, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Feb 20, 2024

  • Use action result type ABI for action return value conversion by ABI.
  • Only attempt conversion if an action return value ABI is available.
  • Updated tests to verify action return value handling.

Note: No replay of data is needed. trace_api_plugin was storing the data correctly on disk.

Merges release/5.0 into main including #2246 & #2247 & #2248

Resolves #2228

@heifner
GH-2228 Correctly handle action return value conversion by ABI
2a10c5d
@heifner
Fix merge
5e34f3e
@heifner
Merge pull request #2246 from AntelopeIO/GH-2228-return-value-3.2
9fbdda0 
[3.2] TraceAPI: Correctly convert return value via ABI
@heifner
Merge remote-tracking branch 'origin/release/3.2' into GH-2228-return…
3c957c1 
…-value-4.0
@heifner
Merge pull request #2247 from AntelopeIO/GH-2228-return-value-4.0
3864468 
[3.2 -> 4.0] TraceAPI: Correctly convert return value via ABI
@heifner
Merge remote-tracking branch 'origin/release/4.0' into GH-2228-return…
2028173 
…-value-5.0-merge
@heifner
GH-2228 Fix merge issue
0a74525
@heifner
Merge pull request #2248 from AntelopeIO/GH-2228-return-value-5.0-merge
0590e02 
[4.0 -> 5.0] TraceAPI: Correctly convert return value via ABI
@heifner
Merge remote-tracking branch 'origin/release/5.0' into GH-2228-return…
998135e 
…-value-main
@heifner heifner added the OCI Work exclusive to OCI team label Feb 20, 2024
@heifner heifner added this to the Leap v6.0.0-rc1 milestone Feb 20, 2024
@heifner heifner merged commit cc8a4d2 into main Feb 20, 2024
26 checks passed
@heifner heifner deleted the GH-2228-return-value-main branch February 20, 2024 21:26
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: BUG
summary: Correctly convert return value via ABI, allowing binary to variant conversation without crashing.
Note:end

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp Awaiting requested review from greg7mdp

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
Leap v6.0.0-rc1
Development

Successfully merging this pull request may close these issues.

_binary_to_variant function crashing on some blocks
4 participants
@heifner @ericpassmore @greg7mdp @linh2931