Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star rating not selecting! #11

Closed
MiguelQueiroz opened this issue Feb 7, 2014 · 2 comments
Closed

Star rating not selecting! #11

MiguelQueiroz opened this issue Feb 7, 2014 · 2 comments

Comments

@MiguelQueiroz
Copy link

Hello.
I'm using chrome v34 on windows 8.1
I cannot select the rating in this case the star rating style.
When i hover on the stars, only the current target gets css hover color, but the ones on the left does not select, and even clicking isn't selecting anything at all. (on IE it works).

I tried to debug it using the minified .js version and what happens is that if I add c=false; right after this line:


" c="ontouchstart" in a; "


then it will work. It must to be something with the touch, or the way chrome handles it. But for me the c=false Hack to overwrite the previous line does it for me.
Also when i go to chrome flags (chrome://flags) and search for the touch handling "Activate touch events MAc, Windows, Linux, Chrome Os - Force support to touch screens" and set it disable, this issue stops. But in my chrome i had by default the "auto", which in this case produces the issue above.

@antennaio
Copy link
Owner

Thanks for the detailed description.

Detecting touch devices reliably is very difficult at the moment, so I simplified things by removing touch detection completely - please try the most recent version and report back to confirm the problems are gone.

@MiguelQueiroz
Copy link
Author

Hi @netboy i think that's it. It does hover correcly according to the demo page ( I assume it does pick the lastest version). I'm glad i could contribute to the bug. Happy coding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants