Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal component's height #146

Closed
3 tasks done
arashsheyda opened this issue May 1, 2023 · 0 comments
Closed
3 tasks done

Modal component's height #146

arashsheyda opened this issue May 1, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@arashsheyda
Copy link
Contributor

Clear and concise description of the problem

I have a small monitor and isSmall computed is trigging true on my monitor:sweat_smile:
so when browsing with pc the details view is full screen

Suggested solution

do you think is it possible to set height.value < 480 or should we check the device type and size?

Alternative

No response

Additional context

related to this PR

Validations
@arashsheyda arashsheyda added the enhancement New feature or request label May 1, 2023
@antfu antfu closed this as completed in 18309b9 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arashsheyda