-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Polar.sh provider #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
May 6, 2024
antfu
reviewed
May 6, 2024
Co-authored-by: Anthony Fu <github@antfu.me>
antfu
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean and prompt implementation!
Merged
Oh wow - thank you so much @Julien-R44 for adding this & @antfu for building this great kit |
StarHeartHunt
pushed a commit
to MooncellWiki/sponsorkit
that referenced
this pull request
May 8, 2024
StarHeartHunt
pushed a commit
to MooncellWiki/sponsorkit
that referenced
this pull request
May 8, 2024
StarHeartHunt
pushed a commit
to MooncellWiki/sponsorkit
that referenced
this pull request
May 8, 2024
Co-authored-by: Anthony Fu <github@antfu.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Polar as provider.
Linked Issues
Close #65
Additional context
There's some information I don't have right now because i am new to Polar.sh. For example : I'm not sure what the
status
of a subscriptions means. Does aninactive
status mean that the person is a past sponsor?I'll soon have answers to these questions, when some people will unsubscribe from my Polar. And I will do a new PR to update the code if there's anything wrong with our implementation. In the meantime, we're just keeping the
active
subscriptions and those with a definedprice
. and it seems to working fine