fix: storage reactivity #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes storage reactivity by reimplementing useAsyncStorage from vueuse and replacing the storage listener on window by a custom one using the polyfill webextension storage API.
|
LGTM |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes storage reactivity by reimplementing useAsyncStorage from vueuse and replacing the storage listener on window by a custom one using the polyfill webextension storage API.
Linked Issues
fix #111
Additional Context
The missing reactivity is very noticeable and anoying if u have a background worker changing any data in the storage. This PR should fix that. In the long term, it might be better to address this issue by exposing additional options in useAsyncStorage.
#151 and this PR will conflict with each other, so some conflict resolving of either one will be required.