New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not throwing "DumpError" in async mode #1

Closed

antfu opened this issue Sep 30, 2016 · 0 comments

Owner

antfu commented Sep 30, 2016

Test passed with this:

c = biconfigs.Biconfigs(path='.test.json', async_write=False)
# class "datetime" is not JSON serializable
with pytest.raises(biconfigs.DumpError):
    c[time.time()] = datetime.datetime.now()

But Failed with this:

c = biconfigs.Biconfigs(path='.test.json', async_write=True)
# class "datetime" is not JSON serializable
with pytest.raises(biconfigs.DumpError):
    c[time.time()] = datetime.datetime.now()

Should check the error thrown in another thread.

antfu closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment