Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing about contributing guidelines #93

Closed
onsummer opened this issue Apr 1, 2022 · 1 comment
Closed

Confusing about contributing guidelines #93

onsummer opened this issue Apr 1, 2022 · 1 comment

Comments

@onsummer
Copy link
Contributor

onsummer commented Apr 1, 2022

Thinking about this rule:

  • Since case-police will only fix words that have both lowercase and uppercase letters, it WON'T convert java to Java. If correct form is a single capitalized word, there is no need to add it to the dictionary.

, is that means if I have a entry:

{
  // ...
  "eslint": "ESLint"
  // ...
}

, case-police will not change eslint to ESLint?

But eslint have already in dict.json, is this guidelines express with confusing?

@antfu
Copy link
Owner

antfu commented Apr 1, 2022

The key in dict is always in lowercase for case insensitive matching, while the full lowercase and full uppercase will be filtered out. ESLint has been commonly misspelled as Eslint or ESlint, which is why it's needed.

@antfu antfu closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants