Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve author list with commas #18

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Conversation

innocenzi
Copy link
Sponsor Contributor

This PR improves the list of authors for a commit by using a comma as a separator and a "and" before the final contributor.

Currently, the output is like the following:

  • Default preflights to preflights layer #1190 by @​CanRau @​antfu

After this PR, the output has a separator:

  • Default preflights to preflights layer #1190 by @​CanRau and @​antfu

If there were more contributors, it would look like this:

  • Default preflights to preflights layer #1190 by @​CanRau, @​innocenzi and @​antfu

@innocenzi innocenzi force-pushed the fix/author-list branch 2 times, most recently from f1126f8 to 88628df Compare June 30, 2022 12:23
@innocenzi innocenzi changed the title feat(contributors): improve author list with commas feat: improve author list with commas Jun 30, 2022
@antfu antfu merged commit 8d8d914 into antfu:main Jun 30, 2022
@innocenzi innocenzi deleted the fix/author-list branch June 30, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants