fix: should not appear deprecated warning #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I used the Patreon provider for SponsorKit, not adding any GitHub tokens (no
SPONSORKIT_LOGIN
andSPONSORKIT_GITHUB_LOGIN
), but show the warning on build time:Because the
getDeprecatedEnv('SPONSORKIT_LOGIN', 'SPONSORKIT_GITHUB_LOGIN')
usingconst value = process.env[name]
to get the global variable, the global variable is a string orundefined
, if the variable is not found is return theundefined
. But it is not equal tonull
, so the deprecation warning appears when the variable is equal toundefined
.https://github.com/antfu/sponsorkit/blob/0c285ea3dd80fed581ab228b9d021ab83554908a/src/env.ts#L4-L9
So this PR resolved the issue.