Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the past sponsors. #25

Closed
3 tasks done
dohooo opened this issue Oct 29, 2022 · 7 comments
Closed
3 tasks done

Display the past sponsors. #25

dohooo opened this issue Oct 29, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@dohooo
Copy link
Contributor

dohooo commented Oct 29, 2022

Clear and concise description of the problem

Maybe we can display the past sponsors because I saw GitHub shows it in the sponsor profile.

Suggested solution

    {
      title: 'Past Sponsors',
      monthlyDollars: -1,
      preset: presets.base,
    },

Alternative

No response

Additional context

No response

Validations

@dohooo dohooo added the enhancement New feature or request label Oct 29, 2022
@dohooo
Copy link
Contributor Author

dohooo commented Oct 31, 2022

Is this ok? I can submit a PR. @antfu

@antfu
Copy link
Member

antfu commented Oct 31, 2022

Sure, PR welcome

@dohooo
Copy link
Contributor Author

dohooo commented Nov 7, 2022

However, It seems GitHub doesn't get past sponsorships from grapgql. The official doesn't add new fields for this feature. But I think we can use playwright for this.

image

image

We can get the username from here. What do you think?

@antfu
Copy link
Member

antfu commented Nov 7, 2022

Using Playwright is probably not a good option for us. We might better request GitHub to expose that API.

@dohooo
Copy link
Contributor Author

dohooo commented Nov 7, 2022

I have asked about this. It seems doesn't want to support this, there have nobody replied to that question.

@dohooo
Copy link
Contributor Author

dohooo commented Nov 7, 2022

Using Playwright is probably not a good option for us. We might better request GitHub to expose that API.

I can create a package to get past sponsorships, and we can import this package into sponsorkit. Then we'll replace it when GitHub exposes that API.

@dohooo
Copy link
Contributor Author

dohooo commented Nov 7, 2022

released, So can I add this feature?

There are some discussions for this feature request.
community/community#38393
community/community#37234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants