Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-wind): add tailwind missing animations #243

Merged
merged 6 commits into from
Dec 9, 2021

Conversation

userquin
Copy link
Member

@userquin userquin commented Dec 9, 2021

Added missing tailwind pulse and bounce, tw-pulse and tw-bounce respectively, spin and ping was already there.

closes #241

@userquin userquin requested a review from antfu as a code owner December 9, 2021 00:30
@netlify
Copy link

netlify bot commented Dec 9, 2021

✔️ Deploy Preview for ecstatic-mestorf-2e8afd ready!

🔨 Explore the source changes: 1bfd28a

🔍 Inspect the deploy log: https://app.netlify.com/sites/ecstatic-mestorf-2e8afd/deploys/61b23dae8bcc6300072f073b

😎 Browse the preview: https://deploy-preview-243--ecstatic-mestorf-2e8afd.netlify.app

@antfu
Copy link
Member

antfu commented Dec 9, 2021

Maybe we should align the unprefixed one with Tailwind and have the one from animated.css as something like pulse-alt?

@userquin
Copy link
Member Author

userquin commented Dec 9, 2021

ok

@userquin
Copy link
Member Author

userquin commented Dec 9, 2021

updated also playground to use animate-bounce-alt

@userquin
Copy link
Member Author

userquin commented Dec 9, 2021

@chris-zhu can you take a look to the changes I've made?

@antfu antfu merged commit 63f2391 into main Dec 9, 2021
@antfu antfu deleted the feat/add-tailwind-animation branch December 9, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

animate-pulse is scaling the object
2 participants