Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async component registration hoisting #44

Merged
merged 7 commits into from
Sep 16, 2021
Merged

Conversation

Demivan
Copy link
Contributor

@Demivan Demivan commented Sep 15, 2021

Fixes #43

Additionally fixed few issues with build on Windows. Can revert.

  • test was trying to run jest.js in the root folder so I renamed the file
  • build and dev could not find source files when using ' instead of "

@antfu
Copy link
Member

antfu commented Sep 15, 2021

Why do we renamed jest to jest-transform?

test was trying to run jest.js in the root folder so I renamed the file

I don't have the problem here. What do you use to run the test?

@antfu antfu changed the title Fix async component registration hoisting fix: async component registration hoisting Sep 16, 2021
@antfu antfu merged commit 10a2735 into unplugin:main Sep 16, 2021
@Demivan
Copy link
Contributor Author

Demivan commented Sep 16, 2021

I was just running pnpm test. It could an issue with PowerShell. Will check.

@Demivan
Copy link
Contributor Author

Demivan commented Sep 16, 2021

@antfu Found the cause: javascriptair/site#98 (comment)

So the problem is there is a js file in the root of repo with the same base name as binary. And npm on windows first tries to run it as binary instead of looking into './node_modules/.bin'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support async component registration
2 participants