Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): support object style templates #34

Merged
merged 6 commits into from
Jun 30, 2023
Merged

feat(template): support object style templates #34

merged 6 commits into from
Jun 30, 2023

Conversation

jd-solanki
Copy link
Contributor

Description

We already have template function but we can't name the template variables for readability.

Linked Issues

N/A

Additional context

Thanks for this package ❤️

@antfu
Copy link
Owner

antfu commented Jun 28, 2023

Maybe we could override the template?

@jd-solanki
Copy link
Contributor Author

You mean, removing existing implementation? I wanted that 😅 but it might break your other package so I created new one.

Do you want to replace the existing template function with this one? I'll be happy to do that.

@jd-solanki
Copy link
Contributor Author

Or you mean method & type overriding? Single function but does both 🤔

@antfu
Copy link
Owner

antfu commented Jun 28, 2023

Or you mean method & type overriding? Single function but does both 🤔

Yes :)

@jd-solanki
Copy link
Contributor Author

Or you mean method & type overriding? Single function but does both 🤔

Yes :)

ohk, I'll try to implement that 👍🏻

@jd-solanki jd-solanki marked this pull request as draft June 28, 2023 11:02
@jd-solanki jd-solanki marked this pull request as ready for review June 29, 2023 06:24
@antfu antfu changed the title feat(namedTemplate): new function feat(template): support object style templates Jun 30, 2023
@antfu antfu merged commit c7bbe2d into antfu:main Jun 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants