Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix redirect not working #37

Conversation

yzydeveloper
Copy link

Description

When I use inspect-plugin and connect-history-api-fallback to server.middlewares at the same time, connect-history-api-fallback will redirect req.url to index.html when rewrite is not found , causing inspect-plugin to fail

Linked Issues

Additional context

@antfu
Copy link
Member

antfu commented Sep 1, 2022

This feels a bit hacky, and I am not very sure. Isn't it should be something to be fixed or configurable on the connect-history-api-fallback side?

@yzydeveloper
Copy link
Author

You look up connect-history-api-fallback line 82, when it doesn't match When it comes to rewrite, it will redirect req.url to /index.html

image

@yzydeveloper yzydeveloper reopened this Sep 7, 2022
@yzydeveloper yzydeveloper deleted the fix-redirect-not-working branch September 7, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants