fix: fix redirect not working #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feels a bit hacky, and I am not very sure. Isn't it should be something to be fixed or configurable on the |
|
You look up connect-history-api-fallback line 82, when it doesn't match When it comes to rewrite, it will redirect req.url to /index.html
|
yzydeveloper
force-pushed
the
fix-redirect-not-working
branch
from
f2c79f0
to
2166075
Compare
This reverts commit 2166075.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I use
inspect-pluginandconnect-history-api-fallbackto server.middlewares at the same time, connect-history-api-fallback will redirect req.url to index.html when rewrite is not found , causing inspect-plugin to failLinked Issues
Additional context