Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage non UTF-8 charset #119

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

antham
Copy link
Owner

@antham antham commented Dec 29, 2023

Fix #13

* Add an automatic conversion to UTF-8 charset to be able to manage formatting
* Add a warning to the README about how non UTF-8 files are managed
@antham antham marked this pull request as ready for review December 29, 2023 14:44
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (94e710f) 91.15% compared to head (af66b75) 90.04%.

Files Patch % Lines
ghokin/file_manager.go 45.45% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   91.15%   90.04%   -1.12%     
==========================================
  Files          12       12              
  Lines         441      452      +11     
==========================================
+ Hits          402      407       +5     
- Misses         27       30       +3     
- Partials       12       15       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antham antham merged commit 6a26806 into master Dec 29, 2023
2 of 4 checks passed
@antham antham deleted the fix-failure-with-non-utf-8-encoding branch December 29, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In tables special characters gets replaced with strange characters, the charset is not managed properly
1 participant