Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last comment indent #28

Merged
merged 2 commits into from Jan 18, 2020
Merged

Fix last comment indent #28

merged 2 commits into from Jan 18, 2020

Conversation

antham
Copy link
Owner

@antham antham commented Jan 18, 2020

Fix #27

@codecov-io
Copy link

codecov-io commented Jan 18, 2020

Codecov Report

Merging #28 into master will increase coverage by 0.51%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   88.52%   89.04%   +0.51%     
==========================================
  Files          10       10              
  Lines         427      429       +2     
==========================================
+ Hits          378      382       +4     
+ Misses         31       30       -1     
+ Partials       18       17       -1
Impacted Files Coverage Δ
ghokin/transformer.go 94.94% <100%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75fc309...bd9595a. Read the comment docs.

when a comment is done on the last line of the file, the indentation follow the previous line instead of
the scenario/background line
@antham antham merged commit ca54d79 into master Jan 18, 2020
@antham antham deleted the fix-last-comment-indent branch January 18, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment indentation is incorrect for last scenario
2 participants