Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving a mode resets Dashboard parameters to their default values #66

Closed
anthonyalfimov opened this issue Sep 18, 2020 · 1 comment
Closed

Saving a mode resets Dashboard parameters to their default values #66

anthonyalfimov opened this issue Sep 18, 2020 · 1 comment
Assignees
@anthonyalfimov
Labels
bug Something isn't working

Comments

@anthonyalfimov
Copy link
Owner

Affected parameters: Note, On Value, Velocity, Y Axis CC.

Currently investigating.
@anthonyalfimov anthonyalfimov added the bug Something isn't working label Sep 18, 2020
@anthonyalfimov anthonyalfimov self-assigned this Sep 18, 2020
@anthonyalfimov
Copy link
Owner Author

Evidently, Dashboard 4.3.0/4.3.1 changed the metadata script behaviour when a mode is loaded: now the onChange scripts are triggered after a mode is loaded. In our case these scripts were used to reset parameters when changing the control type. This causes the bug with the new script behaviour.

Working on a fix.

@SWONIC SWONIC closed this as completed in 9d1a2da Oct 3, 2020
SWONIC added a commit that referenced this issue Oct 3, 2020
@SWONIC
Merge pull request #67 from anthonyalfimov/fix66
d0e4912 
Hotfix 2.0.5 - fix issue #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonyalfimov anthonyalfimov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anthonyalfimov