Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for edit script screen #78

Merged
merged 8 commits into from
Apr 30, 2023
Merged

Fixes for edit script screen #78

merged 8 commits into from
Apr 30, 2023

Conversation

anthonyec
Copy link
Owner

@anthonyec anthonyec commented Apr 30, 2023 •
edited
Loading

Changes

  • Show edit screen UI before bookmark has loaded
  • Create inline and warning variant of Toast component
  • Show warning when script is not valid and won't be visible
  • Clamp bookmark title in toast to limit the height of the notification
  • Remove on change events from edit screen because it causes weird feedback loops. Changes are only reflected in local state and when first loading a bookmark to edit
  • Use React startTransition when loading a new route. It should prevent Suspense showing a fallback but I'm not actually sure it's working. May remove later

@anthonyec anthonyec merged commit b6f9852 into main Apr 30, 2023
@anthonyec anthonyec deleted the edit-script-input-fixes branch April 30, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@anthonyec