Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docker-compose v2 schemas in README.md #112

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Adding docker-compose v2 schemas in README.md #112

merged 3 commits into from
Dec 28, 2020

Conversation

Mylloon
Copy link
Contributor

@Mylloon Mylloon commented Dec 24, 2020

Just adding docker-compose v2 schemas in README.md

@coveralls
Copy link

coveralls commented Dec 24, 2020

Pull Request Test Coverage Report for Build 298

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 86.791%

Files with Coverage Reduction New Missed Lines %
src/main/java/org/araymond/joal/core/bandwith/BandwidthDispatcher.java 1 91.15%
Totals Coverage Status
Change from base Build 295: 0.0%
Covered Lines: 1623
Relevant Lines: 1870

💛 - Coveralls

@anthonyraymond
Copy link
Owner

Hello @Mylloon, please, can you rename the service (youtube-dl), and also move all the environment values to a "command" attribute, just like it is in the regular inline command?

@Mylloon
Copy link
Contributor Author

Mylloon commented Dec 28, 2020

Hello, sorry for the service's name 😓
I'm not sure I can do that, sorry.

@anthonyraymond anthonyraymond merged commit 32051bd into anthonyraymond:master Dec 28, 2020
@anthonyraymond
Copy link
Owner

I've modified it before merge.

Thanks for the Pull Request 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants